Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dehydrated devices feature to work with latest synapse version #1579

Closed
1 task done
nikzen opened this issue Oct 4, 2023 · 1 comment · Fixed by #1614
Closed
1 task done

Update dehydrated devices feature to work with latest synapse version #1579

nikzen opened this issue Oct 4, 2023 · 1 comment · Fixed by #1614
Assignees
@nico-famedly
Labels
improvement

Comments

@nikzen
Copy link
Contributor

nikzen commented Oct 4, 2023 •
edited
Loading

Preflight Checklist

  • I could not find a solution in the existing issues, docs, nor discussions

Describe your problem

The SDK implemented the dehydrated devices feature in the first place. However till our implementation some work has happened on the server side so it is not compatible anymore.

Describe your ideal solution

Update the SDK to work with the dehydrated devices implementation of the latest synapse version.

Version

No response

Security requirements

No response

Additional Context

We need to figure out how to migrate everything.
@techno-disaster techno-disaster self-assigned this Nov 16, 2023
@nico-famedly
Copy link
Member

Okay, so the changes needed are mostly to merge the device key upload with the device creation. Basically you create the device id locally now and then just upload keys and device in one request.

nico-famedly added a commit that referenced this issue Nov 16, 2023
@nico-famedly
feat: Update dehydrated devices implementation to current MSC
2c1d1aa 
BREAKING CHANGE: This replaces the old dehydrated devices
implementation, since there is no way to query what is supported easily
and supporting both would be complicated.

fixes #1579
@nico-famedly nico-famedly mentioned this issue Nov 16, 2023
Merged
nico-famedly added a commit that referenced this issue Nov 16, 2023
@nico-famedly
feat: Update dehydrated devices implementation to current MSC
9f69fb9 
BREAKING CHANGE: This replaces the old dehydrated devices
implementation, since there is no way to query what is supported easily
and supporting both would be complicated.

fixes #1579
nico-famedly added a commit that referenced this issue Nov 16, 2023
@nico-famedly
feat: Update dehydrated devices implementation to current MSC
cda8968 
BREAKING CHANGE: This replaces the old dehydrated devices
implementation, since there is no way to query what is supported easily
and supporting both would be complicated.

fixes #1579
@techno-disaster techno-disaster removed their assignment Nov 17, 2023
nico-famedly added a commit that referenced this issue Nov 24, 2023
@nico-famedly
feat: Update dehydrated devices implementation to current MSC
f631c21 
BREAKING CHANGE: This replaces the old dehydrated devices
implementation, since there is no way to query what is supported easily
and supporting both would be complicated.

fixes #1579
nico-famedly added a commit that referenced this issue Nov 28, 2023
@nico-famedly
feat: Update dehydrated devices implementation to current MSC
2fca087 
BREAKING CHANGE: This replaces the old dehydrated devices
implementation, since there is no way to query what is supported easily
and supporting both would be complicated.

fixes #1579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nico-famedly nico-famedly

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Update dehydrated devices implementation to current MSC famedly/matrix-dart-sdk
3 participants
@nikzen @techno-disaster @nico-famedly