-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose gcp.resourceLabels field in the gcp plugin #544
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pirrofra The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @pirrofra! It looks like this is your first PR to falcosecurity/plugins 🎉 |
f398ade
to
00bee35
Compare
Two small comments: Please bump the version of the plugin here |
Rules files suggestionsrulesComparing No changes detected |
dedac44
to
0c00ce5
Compare
0c00ce5
to
c725709
Compare
Signed-off-by: Francesco Pirrò <[email protected]>
Signed-off-by: Francesco Pirrò <[email protected]>
Signed-off-by: Francesco Pirrò <[email protected]>
c725709
to
7b0fdac
Compare
Rules files suggestionsrulesComparing No changes detected |
Signed-off-by: Francesco Pirrò <[email protected]>
a5e40fa
to
0f3b7eb
Compare
Rules files suggestionsrulesComparing No changes detected |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
On the GCP Plugin we already expose the resource type via the
gcp.resourceType
field. Given that the log-entry also supports alabels
field which can contains useful information for correctly identifying a resource on GCP, we want to expose that using a newgcp.resourceLabels
field.This field will contain the JSON representation of the labels attached on the cloud log entry.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: