Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose gcp.resourceLabels field in the gcp plugin #544

Closed

Conversation

pirrofra
Copy link
Contributor

@pirrofra pirrofra commented Nov 20, 2024

What type of PR is this?
/kind feature

Any specific area of the project related to this PR?
/area plugins

What this PR does / why we need it:
On the GCP Plugin we already expose the resource type via the gcp.resourceType field. Given that the log-entry also supports a labels field which can contains useful information for correctly identifying a resource on GCP, we want to expose that using a new gcp.resourceLabels field.
This field will contain the JSON representation of the labels attached on the cloud log entry.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link
Contributor

poiana commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pirrofra
Once this PR has been reviewed and has the lgtm label, please assign ahmedameenaim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Nov 20, 2024

Welcome @pirrofra! It looks like this is your first PR to falcosecurity/plugins 🎉

@SKosier
Copy link
Contributor

SKosier commented Nov 20, 2024

Two small comments:

Please bump the version of the plugin here
And add the new extraction to the README

@poiana poiana added size/S and removed size/XS labels Nov 20, 2024
Copy link

Rules files suggestions

rules

Comparing dedac44e0f2e17c38450f011d53ebb9c5c371a26 with latest tag plugins/gcpaudit/v0.4.0

No changes detected

@pirrofra pirrofra force-pushed the pirrofra/gcp/resourceLabels branch from dedac44 to 0c00ce5 Compare November 20, 2024 15:29
@pirrofra pirrofra marked this pull request as ready for review November 20, 2024 15:29
@poiana poiana requested a review from LucaGuerra November 20, 2024 15:29
@pirrofra pirrofra force-pushed the pirrofra/gcp/resourceLabels branch from 0c00ce5 to c725709 Compare November 20, 2024 15:30
@pirrofra pirrofra force-pushed the pirrofra/gcp/resourceLabels branch from c725709 to 7b0fdac Compare November 20, 2024 15:43
Copy link

Rules files suggestions

rules

Comparing c725709ab08ac31579161385861ea3cd10554660 with latest tag plugins/gcpaudit/v0.4.0

No changes detected

@pirrofra pirrofra force-pushed the pirrofra/gcp/resourceLabels branch from a5e40fa to 0f3b7eb Compare November 20, 2024 15:50
Copy link

Rules files suggestions

rules

Comparing 0f3b7eb1016aad6f548fa10983802c4636142b0e with latest tag plugins/gcpaudit/v0.4.0

No changes detected

@pirrofra pirrofra closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants