Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proc/scan): scan all existing threads #537

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Nov 6, 2024

By scanning only /proc we missed the threads of a given process. It scans all threads under a given process in /proc/pid/task.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

By scanning only /proc we missed the threads of a given process.
It scans all threads under a given process in /proc/pid/task.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana added kind/bug Something isn't working dco-signoff: yes labels Nov 6, 2024
@poiana poiana added the size/L label Nov 6, 2024
@alacuku alacuku force-pushed the kcl/fix-k8smeta-proc-scan branch from 455daa6 to 93f374c Compare November 6, 2024 14:19
@poiana poiana added size/M and removed size/L labels Nov 6, 2024
@alacuku alacuku force-pushed the kcl/fix-k8smeta-proc-scan branch from 93f374c to cf94973 Compare November 6, 2024 15:57
Copy link

github-actions bot commented Nov 6, 2024

Rules files suggestions

By scanning only /proc we missed the threads of a given process.
It scans all threads under a given process in /proc/pid/task.

Signed-off-by: Aldo Lacuku <[email protected]>
@alacuku alacuku force-pushed the kcl/fix-k8smeta-proc-scan branch from cf94973 to 46ddda0 Compare November 6, 2024 16:35
Copy link

github-actions bot commented Nov 6, 2024

Rules files suggestions

@leogr leogr requested a review from LucaGuerra November 6, 2024 17:16
@poiana
Copy link
Contributor

poiana commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Nov 7, 2024

LGTM label has been added.

Git tree hash: cfbe98e41ece0ccf81199752065947c45f32ff76

@poiana poiana added the approved label Nov 7, 2024
@poiana poiana merged commit b5b9a4d into falcosecurity:main Nov 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants