cleanup(libsinsp): cleanup unaligned access in plugin framework+tests #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Guerra <[email protected]>
LucaGuerra
force-pushed
the
cleanup/remove-ub-plugins
branch
from
f04e6a7 to
ab8f6fa
Compare
jasondellaluce
approved these changes
Feb 8, 2024
|
LGTM label has been added. Git tree hash: 1dfe37b507a8da5eb452f56e2d4e4b89593c1369
|
|
/milestone 0.15.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This is part of this effort: #1470
This current PR deals with plugins, note that it introduces a dependency from the plugin tests to the scap library in order to use the
scap_event_encode_paramsfunction which allows the test classes to easily create events without misaligned reads or writes.It looks like the sinsp test suite is are currently at 7 errors with UBSan.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: