Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(libsinsp): remove HAS_CAPTURE #1671

Merged
merged 1 commit into from
Feb 6, 2024
Merged

cleanup(libsinsp): remove HAS_CAPTURE #1671

merged 1 commit into from
Feb 6, 2024

Conversation

therealbobo
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana poiana requested review from hbrueckner and Molter73 February 1, 2024 10:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@poiana poiana added size/L and removed size/M labels Feb 1, 2024
@poiana poiana added size/M and removed size/L labels Feb 1, 2024
jasondellaluce
jasondellaluce previously approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

This is great

@poiana poiana added the lgtm label Feb 2, 2024
@poiana
Copy link
Contributor

poiana commented Feb 2, 2024

LGTM label has been added.

Git tree hash: 9e3a68b336a663982b96de607e7fec2de34c22ff

@poiana poiana added the approved label Feb 2, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Feb 6, 2024

Is this still a draft? :D

@therealbobo
chore: remove HAS_CAPTURE define
f519ddb 
Signed-off-by: Roberto Scolaro <[email protected]>
@poiana poiana removed the lgtm label Feb 6, 2024
@poiana poiana requested a review from jasondellaluce February 6, 2024 09:48
@therealbobo therealbobo changed the title [EXPERIMENTING]: remove HAS_CAPTURE cleanup(libsinsp): remove HAS_CAPTURE Feb 6, 2024
@therealbobo therealbobo marked this pull request as ready for review February 6, 2024 09:48
@poiana poiana requested a review from FedeDP February 6, 2024 09:48
@Andreagit97 Andreagit97 added this to the 0.15.0 milestone Feb 6, 2024
@therealbobo
Copy link
Contributor Author

just rebased! :)

FedeDP
FedeDP approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Feb 6, 2024
@poiana
Copy link
Contributor

poiana commented Feb 6, 2024

LGTM label has been added.

Git tree hash: 53f268c3fa5d001d8e25c808abf16cdd7daf99d4

Andreagit97
Andreagit97 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

jasondellaluce
jasondellaluce approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97
Copy link
Member

/unhold

@poiana poiana merged commit efa1365 into falcosecurity:master Feb 6, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@Molter73 Molter73 Awaiting requested review from Molter73

Assignees

@FedeDP FedeDP

@jasondellaluce jasondellaluce

@Andreagit97 Andreagit97

Labels
approved dco-signoff: yes kind/cleanup lgtm release-note-none size/M
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@therealbobo @poiana @FedeDP @Andreagit97 @jasondellaluce