fix(userspace/libsinsp/test): put a bound to threat table max size test #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dellaluce <[email protected]>
incertum
approved these changes
Jan 31, 2024
|
LGTM label has been added. Git tree hash: e1d06ec1a5be3a63cb88fc0ff53d0fbfaf482def
|
|
/milestone 0.15.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, incertum, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
The
sinsp_with_test_input.THRD_TABLE_max_table_sizetook a while to execute locally and also made my machine crash, which didn't make much sense to me. Looking closer, the max thread table size is a quite large number and it has also been increased. I changed this to set a fixed size for the sake of the test, still with a reasonably-high number so that it keeps being valuable.Special notes for your reviewer:
Does this PR introduce a user-facing change?: