fix(userspace/libsinsp/test): avoid deadlocks in mpsc queue tests #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dellaluce <[email protected]>
poiana
added
release-note-none
kind/bug
This will hopefully accomodate the Windows runners of our CI, which seem to produce ~64 elements per second :/ Signed-off-by: Jason Dellaluce <[email protected]>
leogr
approved these changes
Feb 1, 2024
|
LGTM label has been added. Git tree hash: d8d28af59bbb75f63fa665d5d1ec54824203c381
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
Nah
What this PR does / why we need it:
We're experiencing deadlocks on the concurrent tests on the MPSC priority queue, so far only on aarch64 in our CI. This may either reveal a thread-safety issue in the queue's implementation, or may just be pathological due to the scheduler being unpredictable -- the queue can order elements already pushed, but can't know if an higher-priority event is not yet pushed due to its producer being sleepy. This PR solves the issue by making the test fail with a timeout, and provides more in-depth messages about the failure. Also, the exit condition of the loop was still faulty in case of out-of-order elements, so this should also be cleared now.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: