fix(modern_bpf): fix args/env retrival in case of large args/env #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
therealbobo
changed the title
Signed-off-by: Roberto Scolaro <[email protected]>
therealbobo
force-pushed
the
fix-mbpf-large-execve
branch
from
c9baad4 to
067626e
Compare
therealbobo
changed the title
|
LGTM label has been added. Git tree hash: 91343489eaa771e5661e92c9b2fe1c37248bea27
|
Andreagit97
reviewed
Jan 31, 2024
Signed-off-by: Roberto Scolaro <[email protected]>
Andreagit97
reviewed
Jan 31, 2024
|
LGTM label has been added. Git tree hash: 013296a9e08e3fcee6d7c24ae31cf6e72661cca3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, incertum, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libscap-engine-modern-bpf
Does this PR require a change in the driver versions?
What this PR does / why we need it:
In case of an
execvelarge args/env, this permits to correctly retrieve those. Otherwise no arg/env is retrieved.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This behaviour is not 100% identical to the kmod behaviour: the kmod subtract the len of
argv[0]when retriving args; on the other hand the modern bpf starts fromargv[1]and tries to read the max amount allowed.Does this PR introduce a user-facing change?: