refactor(userspace/libsinsp)!: deprecate gen_event class family #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasondellaluce
force-pushed
the
refactor/deprecate-gen-event-classes
branch
from
639e8ed to
1be9eb6
Compare
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
…omparison values Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
jasondellaluce
force-pushed
the
refactor/deprecate-gen-event-classes
branch
from
1be9eb6 to
a967fcf
Compare
|
/milestone 0.15.0 |
Andreagit97
approved these changes
Feb 1, 2024
|
LGTM label has been added. Git tree hash: b3238a3887e6e248120d314e62ecda5289f89e70
|
leogr
approved these changes
Feb 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind design
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Back in the days, when we used to implement support to k8s audit logs from within Falco's core code, the libs codebase operated a refactor of the basic classes of libsinsp (i.e. event, filter, filter checks, formatter, and factories) that consisted in extracting base interfaces for all of them. Those interfaces had the
gen_eventprefix and used to be extended by both the regular libsinsp components and the Falco's C++ k8s audit detection implementation.At current times, k8s audit support has been ported to the plugin system about one year and a half ago. The purpose of these classes is now missing, and just create degrees of ambiguity and code duplication. This PR aims to do a big cleanup by going have to have one single definition for all the duplicated sinsp constructs.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: