Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kmod): safer ppm_get_mm_exe_file #1341

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

deepskyblue86
Copy link
Contributor

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area driver-kmod

Does this PR require a change in the driver versions?

What this PR does / why we need it:
Leverage get_file_rcu being a define to use the safer version of get_mm_exe_file.
This will allow kernel versions prior to 4.1, but with the fix being backported don't suffer RCU violations.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(kmod): safer ppm_get_mm_exe_file

Leverage `get_file_rcu` being a define to use the safer version of
`get_mm_exe_file`.
This will allow kernel versions prior to 4.1, but with the fix being
backported don't suffer RCU violations.

Co-authored-by: Joseph Pittman <[email protected]>
Signed-off-by: Angelo Puglisi <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Please double check driver/API_VERSION file. See versioning.

/hold

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 8, 2023

LGTM label has been added.

Git tree hash: 8112dc13fb438d3f7eea44c32dd923fcead8fb36

@poiana poiana added the approved label Sep 8, 2023
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, deepskyblue86, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97 Andreagit97 added this to the 0.13.0 milestone Sep 8, 2023
@FedeDP
Copy link
Contributor

FedeDP commented Sep 8, 2023

Driver 6.0.1 incoming? @Andreagit97

@Andreagit97
Copy link
Member

/unhold

@poiana poiana merged commit 92d0574 into falcosecurity:master Sep 8, 2023
28 checks passed
@deepskyblue86 deepskyblue86 deleted the fix-ppm_get_mm_exe_file branch September 8, 2023 11:39
@FedeDP
Copy link
Contributor

FedeDP commented Sep 13, 2023

/milestone 6.0.1+driver

@poiana poiana modified the milestones: 0.13.0, 6.0.1+driver Sep 13, 2023
@Andreagit97 Andreagit97 modified the milestones: 6.0.1+driver, 0.13.0 Sep 13, 2023
@FedeDP
Copy link
Contributor

FedeDP commented Sep 13, 2023

/milestone 6.0.1+driver

@poiana poiana modified the milestones: 0.13.0, 6.0.1+driver Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants