fix(auth/gcp): ensure correct OAuth scope for Artifact Registry with service account #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @evict! It looks like this is your first PR to falcosecurity/falcoctl 🎉 |
|
@evict, commits are missing the |
…service account Adjusted OAuth scope to `https://www.googleapis.com/auth/cloud-platform` for compatibility with both service account and Workload Identity setups, resolving invalid scope errors when accessing Artifact Registry. Signed-off-by: Vincent <[email protected]>
evict
force-pushed
the
vr/falcoctl/work-with-sa-gcp
branch
from
84a18c6
to
c2dfb9b
Compare
Ah! Somehow interpreted that a core contributor had to sign these off. 😅 Fixed! |
leogr
approved these changes
Nov 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evict, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 1835d502bac882c04311a835438c1bd5e697146f
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted OAuth scope to
https://www.googleapis.com/auth/cloud-platformfor compatibility with both service account and Workload Identity setups, resolving invalid scope errors when accessing Artifact Registry.What type of PR is this?
Any specific area of the project related to this PR?
What this PR does / why we need it:
This PR fixes an issue with OAuth authentication when accessing Google Artifact Registry using a service account. By ensuring the correct scope (https://www.googleapis.com/auth/cloud-platform) is specified, this update resolves token retrieval errors and makes the authentication process compatible with both service account and Workload Identity configurations. This fix is essential for smooth integration with Artifact Registry, especially in environments leveraging Workload Identity on GKE.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: