Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmd): remove redundant configuration for error handling #337

Merged

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Oct 26, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:

Configure in the root command the error and usage messages. Removed redundant configuration in the child commands.

Furthermore, rewrite the tests for the root command using the ginkgo framework.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Furthemore, rewrite the tests for the root command using the ginkgo framework.

Signed-off-by: Aldo Lacuku <[email protected]>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 27, 2023

LGTM label has been added.

Git tree hash: 1413dd73daa088c962c009a9832b39d0f9bb7e65

@poiana
Copy link
Contributor

poiana commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 49e73bb into falcosecurity:main Oct 27, 2023
14 checks passed
@alacuku alacuku deleted the kcl/uniform-command-configuration branch November 3, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants