wip: update(internal/follower): handle required engine version mismatch wi… #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th integers and semvers Signed-off-by: Lorenzo Susini <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: loresuso The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold until we have the changes in Falco |
loresuso
changed the title
|
Putting this on wip, cause the problem could be more complicated then expected. I'll post details on a separate issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…th integers and semvers
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area library
What this PR does / why we need it:
This PR tries to add some resilience when handling the requirement for
engine_version. As it can be seen from PR falcosecurity/falco#2838, theengine_versionis converted from an integer number to a server string. Falcoctl already has the capability to verify both integers and semver requirements, but can't handle the mismatch that this PR is creating. We will have a case in which we stored an integer number in theconfiglayer of a rule artifact as engine version, but the new Falco will return a semver string, that certainly cannot be casted to an int. This PR treats this mismatch as a special one, makingfalcoctlmore resilient in this situation, converting the int to an implicit semver string.This allows us to not republish old artifacts with a semver string in the config, without disruption for users.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: