add some log messages to inform user when generating the tls certificates

.golangci.yml

@@ -65,7 +65,6 @@ linters:
   enable:
     - asciicheck
     - bodyclose
-    - depguard
     - dogsled
     - dupl
     - errcheck

cmd/root.go

@@ -54,7 +54,7 @@ func New(ctx context.Context, opt *options.Common) *cobra.Command {
 	opt.AddFlags(rootCmd.PersistentFlags())
 
 	// Commands
-	rootCmd.AddCommand(tls.NewTLSCmd())
+	rootCmd.AddCommand(tls.NewTLSCmd(opt))
 	rootCmd.AddCommand(version.NewVersionCmd(opt))
 	rootCmd.AddCommand(registry.NewRegistryCmd(ctx, opt))
 	rootCmd.AddCommand(index.NewIndexCmd(ctx, opt))

cmd/tls/install/install.go

@@ -18,6 +18,7 @@ import (
 	"github.com/spf13/cobra"
 
 	"github.com/falcosecurity/falcoctl/pkg/install/tls"
+	commonoptions "github.com/falcosecurity/falcoctl/pkg/options"
 )
 
 // Defaults.
@@ -30,8 +31,9 @@ const (
 )
 
 // NewTLSInstallCmd returns the tls install command.
-func NewTLSInstallCmd() *cobra.Command {
+func NewTLSInstallCmd(opt *commonoptions.Common) *cobra.Command {
 	options := tls.Options{}
+	options.Common = opt
 
 	cmd := &cobra.Command{
 		Use:                   "install",

cmd/tls/tls.go

@@ -18,10 +18,11 @@ import (
 	"github.com/spf13/cobra"
 
 	"github.com/falcosecurity/falcoctl/cmd/tls/install"
+	commonoptions "github.com/falcosecurity/falcoctl/pkg/options"
 )
 
 // NewTLSCmd return the tls command.
-func NewTLSCmd() *cobra.Command {
+func NewTLSCmd(opt *commonoptions.Common) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:                   "tls",
 		TraverseChildren:      true,
@@ -30,7 +31,7 @@ func NewTLSCmd() *cobra.Command {
 		Long:                  `Generate and install TLS material for Falco`,
 	}
 
-	cmd.AddCommand(install.NewTLSInstallCmd())
+	cmd.AddCommand(install.NewTLSInstallCmd(opt))
 
 	return cmd
 }

pkg/install/tls/generator.go

@@ -26,6 +26,8 @@ import (
 	"os"
 	"path/filepath"
 	"time"
+
+	"github.com/falcosecurity/falcoctl/pkg/output"
 )
 
 // A GRPCTLS represents a TLS Generator for Falco.
@@ -239,7 +241,7 @@ func (g *GRPCTLS) GenerateClient(caTemplate *x509.Certificate, caKey DSAKey, not
 }
 
 // FlushToDisk is used to persist the cert material from a GRPCTLS to disk given a path.
-func (g *GRPCTLS) FlushToDisk(path string) error {
+func (g *GRPCTLS) FlushToDisk(path string, logger *output.Printer) error {
 	p, err := satisfyDir(path)
 	if err != nil {
 		return fmt.Errorf("invalid path: %w", err)
@@ -248,11 +250,13 @@ func (g *GRPCTLS) FlushToDisk(path string) error {
 
 	for _, name := range certsFilenames {
 		f := filepath.Join(path, name)
+		logger.Info.Printf("Saving %s to %s\n", name, path)
 		if err := os.WriteFile(f, g.certs[name].Bytes(), 0o600); err != nil {
 			return fmt.Errorf("unable to write %q: %w", name, err)
 		}
 	}
 
+	logger.Info.Println("Done generating the TLS certificates")
 	return nil
 }
 

pkg/install/tls/handler.go

@@ -18,6 +18,8 @@ import (
 	"crypto/elliptic"
 	"fmt"
 	"os"
+
+	commonoptions "github.com/falcosecurity/falcoctl/pkg/options"
 )
 
 // Options represents the `install tls` command o.
@@ -31,6 +33,8 @@ type Options struct {
 	DNSSANs   []string
 	IPSANs    []string
 	Algorithm string
+
+	Common *commonoptions.Common
 }
 
 // Run executes the business logic of the `install tls` command.
@@ -44,6 +48,8 @@ func (o *Options) Run() error {
 		o.Path = cwd
 	}
 
+	o.Common.Printer.Info.Printf("Generating certificates in %s directory\n", o.Path)
+
 	keyGenerator := NewKeyGenerator(DSAType(o.Algorithm))
 
 	switch DSAType(o.Algorithm) {
@@ -77,10 +83,5 @@ func (o *Options) Run() error {
 		return err
 	}
 
-	err = generator.FlushToDisk(o.Path)
-	if err != nil {
-		return err
-	}
-
-	return nil
+	return generator.FlushToDisk(o.Path, o.Common.Printer)
 }