-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: new tests #293
chore: new tests #293
Conversation
84289dd
to
c22afd0
Compare
I moved the test files so we can run tests separately if needed (e.g. |
3554a49
to
7cb565a
Compare
7cb565a
to
69f2961
Compare
55294ff
to
55bcdc3
Compare
55593b4
to
d0164e3
Compare
2224ef7
to
1a6331d
Compare
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
1a6331d
to
f960637
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
LGTM label has been added. Git tree hash: 48c9e12eb5b69a839178dbd1afd2de5123dad970
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, FedeDP, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area tests
What this PR does / why we need it:
This is a general refactor and adds tests for various subcommands:
install
push
pull
auth
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: