Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new tests #293

Merged
merged 2 commits into from
Aug 30, 2023
Merged

chore: new tests #293

merged 2 commits into from
Aug 30, 2023

Conversation

therealbobo
Copy link
Contributor

@therealbobo therealbobo commented May 25, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area tests

What this PR does / why we need it:

This is a general refactor and adds tests for various subcommands:

  • install
  • push
  • pull
  • auth

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@therealbobo
Copy link
Contributor Author

I moved the test files so we can run tests separately if needed (e.g. go test -run 'TestPush' -v -cover ./...). Obviously these are not all the tests but I think that for this PR is enough. I'll continue to add new tests in a new PR. 😄

pkg/test/registry.go Fixed Show fixed Hide fixed
pkg/test/registry.go Fixed Show fixed Hide fixed
pkg/test/registry.go Fixed Show fixed Hide fixed
@therealbobo therealbobo force-pushed the chore/new-tests branch 2 times, most recently from 3554a49 to 7cb565a Compare June 6, 2023 09:52
@leogr leogr added this to the v0.6.0 milestone Jun 6, 2023
@therealbobo therealbobo force-pushed the chore/new-tests branch 3 times, most recently from 55294ff to 55bcdc3 Compare June 7, 2023 14:10
@therealbobo therealbobo force-pushed the chore/new-tests branch 3 times, most recently from 55593b4 to d0164e3 Compare June 23, 2023 08:06
@therealbobo therealbobo force-pushed the chore/new-tests branch 4 times, most recently from 2224ef7 to 1a6331d Compare August 3, 2023 10:35
Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@poiana
Copy link
Contributor

poiana commented Aug 30, 2023

LGTM label has been added.

Git tree hash: 48c9e12eb5b69a839178dbd1afd2de5123dad970

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
/approve

@poiana
Copy link
Contributor

poiana commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 95fdff8 into falcosecurity:main Aug 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants