fix(decl): potential nil ptr deref and shell script SIGUSR handling #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix SIGUSR1 handling by resetting the associated exit code (138) after handler execution. Comment shell script. Signed-off-by: Leonardo Di Giovanna <[email protected]> Co-authored-by: Aldo Lacuku <[email protected]>
Signed-off-by: Leonardo Di Giovanna <[email protected]> Co-authored-by: Aldo Lacuku <[email protected]>
ekoops
changed the title
Disable shell script execution if both "before" and "after" scripts are not provided. Signed-off-by: Leonardo Di Giovanna <[email protected]> Co-authored-by: Aldo Lacuku <[email protected]>
ekoops
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, ekoops The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 264bc63b69d6e52fdd049cb38208a7da6276804c
|
poiana
merged commit 43ce926
into
falcosecurity:declarative-testing
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area pkg
What this PR does / why we need it:
This PR fixes the
SIGUSR1signal handling for shell scripts by correctly handling the exit code set by the signal (138). The first instruction after the blockingwaitnow verifies the returned exit code and clears its value if it matches the one set by the signal. Moreover, this PR fixes a potential nil pointer dereference in test context validation and conditionally disable shell script execution when both "before" and "after" scripts are not provided by the user.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: