-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add support for testing falco rules using declarative YAML files in event-generator #211
Feature: Add support for testing falco rules using declarative YAML files in event-generator #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very random comments after a very first look :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions.
Please use conventional commits and squash them.
- Added a new subcommand declarative for run command - Implemented parsing of YAML test files - Added HostRunner for executing tests on the host - Setup and Cleanup scripts execution - Steps execution for write syscall - Added detailed error handling and logging - Ensure continuation of test even if one fails - Added required helpers to test rule Write Below Root and Write Below Etc Signed-off-by: GLVS Kiriti <[email protected]>
fbf1e9f
to
9ab3066
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: fc7e525e5f896819d08b4901e558b8e19a249163
|
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, FedeDP, GLVSKiriti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
This PR is to add support for testing falco rules using declarative YAML files in event-generator. The implementation idea is here
Which issue(s) this PR fixes:
Part of GSoC 2024 project "Falco: Upgrading event-generator and automating Falco performance testing"
falcosecurity/evolution#362
Special notes for your reviewer:
cc @jasondellaluce @alacuku