adding an event on interpreted procs inbound network activity
#167
Conversation
h4l0gen
changed the title
interpreted procs inbound network activityinterpreted procs inbound network activity
|
The Rule triggered successfully |
h4l0gen
changed the title
interpreted procs inbound network activityinterpreted procs inbound network activity
|
@leogr please give your thoughts on |
events/helper/inbound_connection.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| fmt.Println("Server started on", address) |
There was a problem hiding this comment.
| fmt.Println("Server started on", address) | |
| fmt.Println("Server started on", address) |
Please, use the integrated log system or remove this completely.
events/helper/inbound_connection.go
Outdated
| } | ||
| fmt.Println("Server started on", address) | ||
| defer listener.Close() | ||
| fmt.Println("Server closed on", address) |
There was a problem hiding this comment.
| fmt.Println("Server closed on", address) | |
| fmt.Println("Server closed on", address) |
This is not accurate since the sever will be actually closed after func listener.Close() returns. I just propose to remove this line.
| listener, err := net.ListenTCP("tcp4", &net.TCPAddr{IP: ip}) | ||
| if err != nil { | ||
| continue | ||
| } | ||
| listener.Close() |
There was a problem hiding this comment.
Shouldn't this already trigger the rules? 🤔
There was a problem hiding this comment.
No @leogr I've checked by removing and modifying it. To trigger rule we need to create listener here.
|
Hey @leogr, thanks for your valuable review, I will look into it in some time |
|
Hey @leogr, I made all proposed changes. Please take a look again, whenever you find time. |
Signed-off-by: h4l0gen <[email protected]> adding an event on interpreted procs inbound network activity Signed-off-by: h4l0gen <[email protected]> commits squashed Signed-off-by: h4l0gen <[email protected]> sqaushing commits Signed-off-by: h4l0gen <[email protected]>
|
LGTM label has been added. Git tree hash: 92bbfadacc65253f52074aa7f06ae3beb2796859
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: h4l0gen, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area events
What this PR does / why we need it:
this PR triggers rule
interpreted procs inbound network activityWhich issue(s) this PR fixes:
Fixes #151
Special notes for your reviewer: