From 467c2a270db887cc7324a71300d23f59604a6375 Mon Sep 17 00:00:00 2001
From: Yohan Boyer <25897753+yohboy@users.noreply.github.com>
Date: Wed, 17 Jul 2024 18:38:21 +0200
Subject: [PATCH] fix(falco): mount client-certs-volume only if
 certs.existingClientSecret is defined

Signed-off-by: Yohan Boyer <25897753+yohboy@users.noreply.github.com>
---
 charts/falco/CHANGELOG.md               | 4 ++++
 charts/falco/Chart.yaml                 | 2 +-
 charts/falco/README.md                  | 2 +-
 charts/falco/templates/pod-template.tpl | 2 +-
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/charts/falco/CHANGELOG.md b/charts/falco/CHANGELOG.md
index 00aeb4fdc..ba5a941f0 100644
--- a/charts/falco/CHANGELOG.md
+++ b/charts/falco/CHANGELOG.md
@@ -3,6 +3,10 @@
 This file documents all notable changes to Falco Helm Chart. The release
 numbering uses [semantic versioning](http://semver.org).
 
+## v4.6.3
+
+* fix(falco): mount client-certs-volume only if certs.existingClientSecret is defined
+
 ## v4.6.2
 
 * bump falcosidekick dependency to v0.8.* to match with future versions
diff --git a/charts/falco/Chart.yaml b/charts/falco/Chart.yaml
index d1121d05d..de5266752 100644
--- a/charts/falco/Chart.yaml
+++ b/charts/falco/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: falco
-version: 4.6.2
+version: 4.6.3
 appVersion: "0.38.1"
 description: Falco
 keywords:
diff --git a/charts/falco/README.md b/charts/falco/README.md
index 42cdcdc56..478a3c251 100644
--- a/charts/falco/README.md
+++ b/charts/falco/README.md
@@ -581,7 +581,7 @@ If you use a Proxy in your cluster, the requests between `Falco` and `Falcosidek
 
 ## Configuration
 
-The following table lists the main configurable parameters of the falco chart v4.6.2 and their default values. See [values.yaml](./values.yaml) for full list.
+The following table lists the main configurable parameters of the falco chart v4.6.3 and their default values. See [values.yaml](./values.yaml) for full list.
 
 ## Values
 
diff --git a/charts/falco/templates/pod-template.tpl b/charts/falco/templates/pod-template.tpl
index 376c51772..e66f85503 100644
--- a/charts/falco/templates/pod-template.tpl
+++ b/charts/falco/templates/pod-template.tpl
@@ -190,7 +190,7 @@ spec:
           name: certs-volume
           readOnly: true
         {{- end }}
-        {{- if or .Values.certs.existingSecret (and .Values.certs.client.key .Values.certs.client.crt .Values.certs.ca.crt) }}
+        {{- if or .Values.certs.existingClientSecret (and .Values.certs.client.key .Values.certs.client.crt .Values.certs.ca.crt) }}
         - mountPath: /etc/falco/certs/client
           name: client-certs-volume
           readOnly: true