Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASGI HTTP protocol 2.4: send() may raise OSError #2323

Open
vytas7 opened this issue Sep 6, 2024 · 1 comment
Open

ASGI HTTP protocol 2.4: send() may raise OSError #2323

vytas7 opened this issue Sep 6, 2024 · 1 comment

Comments

@vytas7
Copy link
Member

vytas7 commented Sep 6, 2024

In the ASGI HTTP & WebSocket protocol version 2.4, calling send() on a closed connection should raise an OSError.

...but I haven't really been able to reproduce this in real servers (Uvicorn, Hypercorn).

Also, considering how the flow usually looks like, this is more important for WebSockets, which will be addressed separately in #2292.

@vytas7
Copy link
Member Author

vytas7 commented Nov 20, 2024

This gets probably even less urgent now that Uvicorn has backpedaled on this change, and reverted back to the 2.3 version of the spec: encode/uvicorn#2276.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant