From 1617fd72e10634923f75bb27ca00a23cf2f19ecb Mon Sep 17 00:00:00 2001 From: Athos Ribeiro Date: Thu, 17 Oct 2024 18:24:20 -0300 Subject: [PATCH] test: prevent segfault in imageverifier test When VeriftImage returns an error, the first return value may be set to nil (this is the case for timeouts). When that is the case, it makes no point trying to access its fields later in the test. Let's use testify/require instead of testify/assert here to ensure the test halts upon failure. Signed-off-by: Athos Ribeiro --- pkg/imageverifier/bindir/bindir_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/imageverifier/bindir/bindir_test.go b/pkg/imageverifier/bindir/bindir_test.go index 099f6dc3c42b..000a0b294bde 100644 --- a/pkg/imageverifier/bindir/bindir_test.go +++ b/pkg/imageverifier/bindir/bindir_test.go @@ -175,7 +175,7 @@ func TestBinDirVerifyImage(t *testing.T) { }) j, err := v.VerifyImage(ctx, "registry.example.com/image:abc", ocispec.Descriptor{}) - assert.NoError(t, err) + require.NoError(t, err) assert.True(t, j.OK, "expected OK, got not OK with reason: %v", j.Reason) assert.Less(t, len(j.Reason), len(bins)*(outputLimitBytes+1024), "reason is: %v", j.Reason) // 1024 leaves margin for the formatting around the reason. })