Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test appId no longer valid #686

Open
jonathansampson opened this issue Aug 8, 2024 · 3 comments
Open

Test appId no longer valid #686

jonathansampson opened this issue Aug 8, 2024 · 3 comments

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Aug 8, 2024

This app no longer exists. As a result, the test fails. cc @jbigman

return gplay.app({ appId: 'air.com.zinkia.playset' })

@jonathansampson
Copy link
Contributor Author

That ID appears to be for Pocoyo Playset Learning Games, last updated on April 18, 2017. I cannot find anything that old, but I did find P House - Numbers, which was last updated on October 2, 2017.

Would this be a satisfactory replacement for air.com.zinkia.playset?

@jonathansampson
Copy link
Contributor Author

There are a few appIds which no longer exist, and therefore cause several tests to fail. Or, alternatively, perhaps a test shouldn't fail if an appId yields a 404 response. Instead, those example should be logged and manually reviewed?

@facundoolano
Copy link
Owner

Ideally we should update those tests with new app ids, preferably some big names that are less likely to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants