Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #10

Open
1 of 11 tasks
maxnoe opened this issue Sep 23, 2017 · 3 comments
Open
1 of 11 tasks

Cleanup #10

maxnoe opened this issue Sep 23, 2017 · 3 comments
Assignees

Comments

@maxnoe
Copy link
Member

maxnoe commented Sep 23, 2017

I found the following, old looking scripts which either need to be updated or removed:

  • fact_plots.scripts.combine_data_and_db.py
    Seems to plot stuff about ped var and currents from the db. Has lying doc string (something about effective area) and apparently uses python 2.

  • fact_plots.scripts.plot_data_mc_compare.py

    • Hard coded author in pdf metada Jens Buss
    • Saves single pngs and multi page pdf
  • fact_plots.scripts.plotExtractorPerformance.py

    • Uses python 2
    • uses ROOT to plot stuff
  • fact_plots.plot_numisland_current_mean.py

    • python 2
    • seems not really to be a broadly needed plot
    • has hard coded db access strings
  • plot_ped_std_mean_current_mean

  • plot_ped_var_mean_current_mean

  • plot_pedVarMean_current_mean

The three above seem to do roughly the same, maybe combine?

  • plot_ped_var_nsb_rate

    • python 2
  • plot_XTalk_cleaning_comparison.py

  • plot_XTalk_comparison.py

  • resolution_helper

    • should be obsolete because of plot_bias_resolution.py

Most of these define the same functions over and over, e.g. def combine_data_to_db.py.

@maxnoe
Copy link
Member Author

maxnoe commented Nov 7, 2017

@jebuss @mackaiver can you have a look?

@jebuss
Copy link
Member

jebuss commented Dec 4, 2017

@jebuss @mackaiver can you have a look?

yes

@maxnoe
Copy link
Member Author

maxnoe commented May 17, 2019

Maybe again? And comment which ones can go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants