Capture KeepAlive instead of Executor in WriterOptions #115
+30
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66741079 |
…ator#115) Summary: folly::Executor::KeepAlive<> is the recommended way of holding references to Executors, as they ensure the executor is kept alive until the KeepAlive object is destroyed. Because of this, some folly APIs can only return KeepAlive (and not shared_ptr), such as Global pools. These APIs cannot use WriterOption is it takes a shared_ptr Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66741079
pedroerp
force-pushed
the
export-D66741079
branch
from
17dd2ba to
8f69f60
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66741079 |
|
This pull request has been merged in 68dd6ff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
folly::Executor::KeepAlive<> is the recommended way of holding
references to Executors, as they ensure the executor is kept alive until the
KeepAlive object is destroyed. Because of this, some folly APIs can only return
KeepAlive (and not shared_ptr), such as Global pools.
These APIs cannot use WriterOption is it takes a shared_ptr
Reviewed By: xiaoxmeng
Differential Revision: D66741079