Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add executorBarrier to nimble parallel writer #102

Closed
wants to merge 2 commits into from

Conversation

styoung89
Copy link

Summary: adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Nov 5, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Nov 5, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Nov 5, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Nov 6, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Nov 6, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Nov 6, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Nov 7, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Nov 7, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Nov 7, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Dec 3, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Dec 4, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Dec 4, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Dec 4, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Dec 4, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Reviewed By: helfman

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

styoung89 pushed a commit to styoung89/nimble-1 that referenced this pull request Dec 4, 2024
Summary:

adding executor barrier for the fieldwriter for parallelism

Reviewed By: helfman

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

Scott Young added 2 commits December 4, 2024 11:47
)

Summary:

Switching to pool model for parallelism. Instead of a single shared decodedvector and a single selectivityvector, we get a context of decodedvector and selectivityvector that gets recycled back into a queue

Reviewed By: helfman

Differential Revision: D65379001
Summary:

adding executor barrier for the fieldwriter for parallelism

Reviewed By: helfman

Differential Revision: D64775045
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64775045

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in acdae5a.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 86e1158.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged Reverted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants