From 2ba00420da5af11bed6fe4ceeb38f5b333bab8e8 Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Thu, 21 Nov 2024 18:49:45 -0800 Subject: [PATCH] Remove unused-variable in dwio/nimble/velox/tests/VeloxWriterTests.cpp +3 (#106) Summary: Pull Request resolved: https://github.com/facebookincubator/nimble/pull/106 LLVM-15 has a warning `-Wunused-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with `[[maybe_unused]]`. #buildsonlynotests - Builds are sufficient - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: sdruzkin Differential Revision: D66330541 fbshipit-source-id: 35d916c04e58c25c0cf8dac9983d7375972d8bf9 --- dwio/nimble/velox/tests/VeloxWriterTests.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/dwio/nimble/velox/tests/VeloxWriterTests.cpp b/dwio/nimble/velox/tests/VeloxWriterTests.cpp index a39830e..bc54fa0 100644 --- a/dwio/nimble/velox/tests/VeloxWriterTests.cpp +++ b/dwio/nimble/velox/tests/VeloxWriterTests.cpp @@ -193,8 +193,6 @@ TEST_F(VeloxWriterTests, RootHasNulls) { } TEST_F(VeloxWriterTests, FeatureReorderingNonFlatmapColumn) { - const uint32_t batchSize = 10; - velox::test::VectorMaker vectorMaker{leafPool_.get()}; auto vector = vectorMaker.rowVector( {"map", "flatmap"},