Skip to content

Commit

Permalink
Remove unused-variable in dwio/nimble/velox/tests/VeloxWriterTests.cp…
Browse files Browse the repository at this point in the history
…p +3 (#106)

Summary:
Pull Request resolved: #106

LLVM-15 has a warning `-Wunused-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with `[[maybe_unused]]`.

#buildsonlynotests - Builds are sufficient

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: sdruzkin

Differential Revision: D66330541

fbshipit-source-id: 35d916c04e58c25c0cf8dac9983d7375972d8bf9
  • Loading branch information
r-barnes authored and facebook-github-bot committed Nov 22, 2024
1 parent 32f3238 commit 2ba0042
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions dwio/nimble/velox/tests/VeloxWriterTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,6 @@ TEST_F(VeloxWriterTests, RootHasNulls) {
}

TEST_F(VeloxWriterTests, FeatureReorderingNonFlatmapColumn) {
const uint32_t batchSize = 10;

velox::test::VectorMaker vectorMaker{leafPool_.get()};
auto vector = vectorMaker.rowVector(
{"map", "flatmap"},
Expand Down

0 comments on commit 2ba0042

Please sign in to comment.