Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC warning C4459: declaration of 'cleanup' hides global declaration #554

Open
bobbymcr opened this issue Jul 13, 2023 · 2 comments
Open

Comments

@bobbymcr
Copy link

When using libunifex with MSVC 19.34.31935 and level 4 warnings enabled, I'm seeing this warning:

spawn_future.hpp(736,29): warning C4459: declaration of 'cleanup' hides global declaration
stream_concepts.hpp(77,5): note: see declaration of 'unifex::_streams::cleanup'

If we really want the stream cleanup to be a global declaration we should avoid using the name cleanup elsewhere.

@bobbymcr
Copy link
Author

Seeing similar errors in other places as well:

await_transform.hpp(180,26): warning C4459: declaration of 'sender' hides global declaration
sender_concepts.hpp(192,3): note: see declaration of 'unifex::sender'

@bobbymcr
Copy link
Author

scheduler_concepts.hpp(224,10): warning C4459: declaration of 'scheduler' hides global declaration
scheduler_concepts.hpp(101,3): note: see declaration of 'unifex::scheduler'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant