Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] TextInput fontFamily issue with some keyboards in iOS #48154

Open
kimkanu opened this issue Dec 6, 2024 · 3 comments
Open

[iOS] TextInput fontFamily issue with some keyboards in iOS #48154

kimkanu opened this issue Dec 6, 2024 · 3 comments
Labels
API: Keyboard Component: TextInput Related to the TextInput component. Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Platform: iOS iOS applications.

Comments

@kimkanu
Copy link

kimkanu commented Dec 6, 2024

Description

I'm not sure what the main cause of the issue is, but I ran into an issue with CJK keyboards in iOS, that the fontFamily is not set correctly.

const [text, setText] = useState("");

const fontFamily = !text ? "ZenMaruGothic" : "IMHyemin";

return (
  <SafeAreaView>
    <View style={styles.view}>
      <TextInput
        multiline
        defaultValue={text}
        onChangeText={setText}
        placeholder="フォントテスト"
        style={[styles.textInput, { fontFamily }]}
      />
     {/* ... */}

When the text is typed on keyboards having "pending states" . That is, the state in which the text can be modified by the additional keystrokes and confirmed by the user to be finalized. Examples include:

  • with the Chinese pinyin keyboard, one types nh and selects 你好 to finalize the input
  • with the standard Korean (qwerty) keyboard, keystrokes ㄱㅏ yield (U+AC00) in its pending states, and an additional keystroke modifies it to be (U+AC04)

As you can see in the video, when typed using the standard English keyboard, at the first keystroke, the letter is correctly styled with the provided font. But using Chinese/Japanese keyboards, the first keystroke does not change the font and the following keystrokes change it. Even worse, using the Korean keyboard, the font of the TextInput is not changed at all.

Steps to reproduce

Expo snack: https://snack.expo.dev/@kanukim/textinputfonttest

Issues with Korean characters:

  1. Open the project in an iOS device
  2. Add a Korean Keyboard (Standard)
  3. Type "한글" (FYI, you can type it by pressing ㅎㅏㄴㄱㅡㄹ in sequence)
  4. The fonts are not set correctly (as the text input below)

You may test the issue with various keyboards including Japanese (romaji) and Chinese (pinyin) inputs.

React Native Version

0.76.3

Affected Platforms

Runtime - iOS

Areas

Fabric - The New Renderer

Output of npx react-native info

System:
  OS: macOS 15.1.1
  CPU: (8) arm64 Apple M1
  Memory: 206.56 MB / 8.00 GB
  Shell:
    version: 3.7.1
    path: /opt/homebrew/bin/fish
Binaries:
  Node:
    version: 22.9.0
    path: ~/.local/share/nvm/v22.9.0/bin/node
  Yarn:
    version: 1.22.22
    path: ~/.bun/bin/yarn
  npm:
    version: 10.8.3
    path: ~/.local/share/nvm/v22.9.0/bin/npm
  Watchman:
    version: 2024.09.09.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.14.3
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 24.1
      - iOS 18.1
      - macOS 15.1
      - tvOS 18.1
      - visionOS 2.1
      - watchOS 11.1
  Android SDK:
    API Levels:
      - "33"
      - "34"
    Build Tools:
      - 30.0.3
      - 33.0.0
      - 33.0.1
      - 34.0.0
    Android NDK: Not Found
IDEs:
  Android Studio: 2024.1 AI-241.18034.62.2411.12071903
  Xcode:
    version: 16.1/16B40
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.12
    path: /opt/homebrew/opt/openjdk@17/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli":
    installed: 16.0.0
    wanted: latest
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.76.3
    wanted: 0.76.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Stacktrace or Logs

No errors

Reproducer

https://snack.expo.dev/@kanukim/textinputfonttest

Screenshots and Videos

Screen.Recording.Dec.6.2024.mov

Please focus on the missing font changes at the first keystrokes.

@kimkanu kimkanu added Needs: Triage 🔍 Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) labels Dec 6, 2024
@react-native-bot react-native-bot added API: Keyboard Component: TextInput Related to the TextInput component. Platform: iOS iOS applications. labels Dec 6, 2024
@cortinico cortinico added Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. and removed Needs: Triage 🔍 labels Dec 6, 2024
@cipolleschi
Copy link
Contributor

Does it still happen if you disable the new architecture?

@kimkanu
Copy link
Author

kimkanu commented Dec 10, 2024

@cipolleschi Yes, it does happen without the new arch.

Screen.Recording.2024-12-10.at.14.33.19.mov

Tested on a simulator, with newArchEnabled: false.

https://github.com/kimkanu/TextInputFontTest.git

@cortinico cortinico removed the Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) label Dec 10, 2024
@cipolleschi
Copy link
Contributor

Thanks for testing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: Keyboard Component: TextInput Related to the TextInput component. Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Platform: iOS iOS applications.
Projects
None yet
Development

No branches or pull requests

4 participants