From c778d406a43454d4121fd226a368c194f947b422 Mon Sep 17 00:00:00 2001 From: Alex Hornby Date: Thu, 24 Oct 2024 13:22:40 -0700 Subject: [PATCH] getdeps: enable -fcoroutines for GCC in fb303 and eden Summary: X-link: https://github.com/facebookincubator/zstrong/pull/1019 Enable coroutines on GCC for fb303 and eden OSS cmake builds to match folly and [fbthrift](https://github.com/facebook/fbthrift/blob/197890bbedd4942809b91139f9a2890c8f167045/CMakeLists.txt#L64-L75). This stops the eden tests from immediatedly core dumping when they try to open up the thrift server So can check if core dumps: * fix to eden main.py to stub par_telemetry in OSS where its not available * add the missing getdeps dependency from eden to sapling for tests (it needs the sapling binaries for the tests torun) Reviewed By: jdelliot Differential Revision: D64911998 fbshipit-source-id: f6316908314bd821dd8c0e5afb5fe4584f5be23e --- build/fbcode_builder/manifests/eden | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/build/fbcode_builder/manifests/eden b/build/fbcode_builder/manifests/eden index 168f460e9af..d7bc911612e 100644 --- a/build/fbcode_builder/manifests/eden +++ b/build/fbcode_builder/manifests/eden @@ -55,6 +55,10 @@ python # TODO: teach getdeps to compile lmdb on Windows. lmdb +[dependencies.test=on] +# sapling CLI is needed to run the tests +sapling + [shipit.pathmap.fb=on] # for internal builds that use getdeps fbcode/fb303 = fb303