From 680c9a136bb19d03376cf3755e0aa0f9f678ad3e Mon Sep 17 00:00:00 2001 From: "Gang Zhao (Hermes)" Date: Wed, 5 Jun 2024 17:54:27 -0700 Subject: [PATCH] Upgrade Xcode version and iPhone version in Github Actions (#1420) Summary: Now `macos-latest` aliases to `macos-14`, where `xcode-13.4.1` is not available. Upgrade it to 15.4. Also use iPhone 14 simulator instead of 11 due to error of "test must be run on concrete device". Differential Revision: D58144748 --- .github/workflows/build.yml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a819485917e..b22927ec185 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -79,9 +79,9 @@ jobs: macos: runs-on: macos-latest steps: - - uses: maxim-lobanov/setup-xcode@v1.6.0 + - uses: maxim-lobanov/setup-xcode@v1 with: - xcode-version: 13.4.1 + xcode-version: 15.4 - uses: actions/checkout@v4.1.0 with: path: hermes @@ -115,9 +115,9 @@ jobs: HERMES_WS_DIR: "/tmp/hermes" HOMEBREW_NO_AUTO_UPDATE: 1 steps: - - uses: maxim-lobanov/setup-xcode@v1.6.0 + - uses: maxim-lobanov/setup-xcode@v1 with: - xcode-version: 13.4.1 + xcode-version: 15.4 - uses: actions/checkout@v4.1.0 - name: Cache setup uses: actions/cache@v4.0.0 @@ -142,9 +142,9 @@ jobs: test-macos: runs-on: macos-latest steps: - - uses: maxim-lobanov/setup-xcode@v1.6.0 + - uses: maxim-lobanov/setup-xcode@v1 with: - xcode-version: 13.4.1 + xcode-version: 15.4 - uses: actions/checkout@v4.1.0 with: path: hermes @@ -163,9 +163,9 @@ jobs: HERMES_WS_DIR: "/tmp/hermes" HOMEBREW_NO_AUTO_UPDATE: 1 steps: - - uses: maxim-lobanov/setup-xcode@v1.6.0 + - uses: maxim-lobanov/setup-xcode@v1 with: - xcode-version: 13.4.1 + xcode-version: 15.4 - uses: actions/checkout@v4.1.0 - name: Cache setup uses: actions/cache@v4.0.0 @@ -195,7 +195,7 @@ jobs: xcodebuild test \ -workspace ApplePlatformsIntegrationTests.xcworkspace \ -configuration Debug \ - -destination 'platform=iOS Simulator,name=iPhone 11' \ + -destination 'platform=iOS Simulator,name=iPhone 12' \ -scheme ApplePlatformsIntegrationMobileTests working-directory: test/ApplePlatformsIntegrationTestApp package-apple-runtime: @@ -208,9 +208,9 @@ jobs: HERMES_WS_DIR: "/tmp/hermes" HOMEBREW_NO_AUTO_UPDATE: 1 steps: - - uses: maxim-lobanov/setup-xcode@v1.6.0 + - uses: maxim-lobanov/setup-xcode@v1 with: - xcode-version: 13.4.1 + xcode-version: 15.4 - uses: actions/checkout@v4.1.0 - name: Cache setup uses: actions/cache@v4.0.0 @@ -550,9 +550,9 @@ jobs: test-macos-test262: runs-on: macos-latest steps: - - uses: maxim-lobanov/setup-xcode@v1.6.0 + - uses: maxim-lobanov/setup-xcode@v1 with: - xcode-version: 13.4.1 + xcode-version: 15.4 - uses: actions/checkout@v4.1.0 with: path: hermes