Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AArch64] Add SVE2 version of qfind_first_byte_of #2305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rj-jesus
Copy link

@rj-jesus rj-jesus commented Oct 1, 2024

This patch adds optimised routines for "find first" methods for AArch64 targets that support SVE2. The implementation is based on the already existing SSE routines.

I've placed the new routines in our (NVIDIA) external folder and renamed the NoSSE methods to NoSIMD (please let me know if you have a better suggestion). On Grace, the new routines show very significant speedups on the Range Find benchmark.

This patch adds optimised routines for "find first" methods for AArch64
targets that support SVE2. The implementation is based on the already
existing SSE routines.
@rj-jesus
Copy link
Author

rj-jesus commented Nov 5, 2024

Hi, are there any updates on this?

@facebook-github-bot
Copy link
Contributor

@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Orvid
Copy link
Contributor

Orvid commented Nov 5, 2024

Sorry about that, I somehow missed this PR when you first put it up. I've imported it now and the tests are running.

@rj-jesus
Copy link
Author

rj-jesus commented Nov 6, 2024

No worries! Please let me know if you need anything or have any suggestions.

@rj-jesus
Copy link
Author

Hi, are there any updates on this? :)

@Orvid
Copy link
Contributor

Orvid commented Nov 26, 2024

Still working on the internal version of this to get it compiling properly in all of our build environments (most of it is just getting our internal build system configured properly). Hopefully I've just submitted the final fix for testing, but I've thought that before, so we'll see what happens.

@rj-jesus
Copy link
Author

Thanks for the update, @Orvid! Please let me know if there's anything I can help with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants