-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
montblanc: config: add port 65 in dvt qsfp config #221
Conversation
Hi @zhongedward! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@zhongedward has updated the pull request. You must reimport the pull request before landing. |
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@zhongedward , while this config is a very good reference, Meta does not want to merge this PR because this is not Meta's running config - (it's a good reference, and MEta does not use it as is). Does Celestica need this file here in order to run OSS fboss? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked a question to @zhongedward
@mikechoifb
The Shanghai team will be on a National Day Holiday from Sept 30th to Oct 7th. We will close this PR after they return. |
Description
This PR is for montblanc dvt qsfp config.
Motivation
1.In montblanc dvt machine has added port 65,so we need to add it in qsfp.conf file.
2.Test cmd:
test cmd:
[root@localhost main_137]# LD_LIBRARY_PATH=./fboss_lib/ ./qsfp_hw_test --qsfp-config qsfp_65.conf --gtest_filter=HwTest.i2cStressRead:HwTest.i2cStressWrite:HwTest.cmisPageChange:HwTest.i2cUniqueSerialNumbers --bsp_platform_mapping_override_path ./montblanc_bsp_mapping_dvt_all_port_65.json
Test Plan
1.The correctness of the format has been verified on this website https://jsonlint.com/
2.This PR has used "jq" cmd to pretty the format.
3.The lint issue is not about the json file.
4.Test log as follow:
mp3_dvt_oss_test_qsfp_hw_test_all_65port_test_log_7_30.txt