Skip to content

Commit

Permalink
hook up patch subscribtion api in ShardedSubscribableStorage
Browse files Browse the repository at this point in the history
Summary: This only supports concrete path now. Added support for patch subscription in networkHandler. I did not expose this to NSDB since we should expose the extended subs version instead. In the mean time, we should still need this as building blocks for extended subs

Reviewed By: peygar

Differential Revision: D60695878

fbshipit-source-id: 0d172dbf53453dbb5172dd14a6aee37e370dea9a
  • Loading branch information
Wei-Cheng Lin authored and facebook-github-bot committed Aug 14, 2024
1 parent d0e1330 commit 29194f7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions fboss/fsdb/oper/NaivePeriodicSubscribableStorage.h
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ class NaivePeriodicSubscribableStorage
using Base::subscribe_delta_extended;
using Base::subscribe_encoded;
using Base::subscribe_encoded_extended;
#ifdef ENABLE_PATCH_APIS
using Base::subscribe_patch;
#endif

template <typename T>
Result<T> get_impl(PathIter begin, PathIter end) const {
Expand Down
1 change: 1 addition & 0 deletions fboss/thrift_cow/storage/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ cpp_library(
headers = [
"Storage.h",
],
propagated_pp_flags = ["-DENABLE_PATCH_APIS"],
exported_deps = [
"//fboss/fsdb/if:fsdb_oper-cpp2-types",
"//fboss/thrift_cow:patch-cpp2-types",
Expand Down

0 comments on commit 29194f7

Please sign in to comment.