SyntheticRunner: @property decorator missing for def run_metadata_report_keys()

[ClaasRostock]

module: ax.runners.synthetic
class: SyntheticRunner
method: run_metadata_report_keys()

-> this methods overwrites a property of base class Runner. However, it does not declare the method as a property, though the base class does.

I expect that following test should fail until resolved (at least this is how I got aware of it in my local installation)
module: ax.core.tests.test_experiment
test: test_WarmStartFromOldExperiment() -> line 889 should fail

Best regards

Claas

[Balandat]

Hmm good catch, I'll put up a fix.

Looks like we subclass the runner in the test and actually define this as a property so this is while the test doesn't fail: https://github.com/facebook/Ax/blob/main/ax/core/tests/test_experiment.py#L61-L64

cc @bernardbeckerman as this was introduced in #1869

[bernardbeckerman]

Thanks! Closing this out.