Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skies being shifted down a few pixels compared to Woof 12.0.2 #1608

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

ceski-1
Copy link
Collaborator

@ceski-1 ceski-1 commented Mar 20, 2024

Edit: See comment further down.

old information
  1. Partially fixes walls being drawn slightly differently: Prevent light scale overflow #1605 (comment)
  2. Fixes skies being shifted down a few pixels.

For (1), there are still occasional wall columns that vary slightly. I don't know the cause but it doesn't seem critical at the moment. Here's a zip file with screenshots and a save: woofsav3_shots.zip. Look at the wall in the middle left.

For this PR, I ran a modified version of the HOM test (#1525 (comment)) with the entire range of FOVs and it was fine: hom_with_fov.patch.

Partially fixes small differences in wall rendering between Woof 12 and 14.
Fixes skies being shifted down a few pixels compared to Woof 12.
Copy link
Collaborator

@rfomin rfomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works good for me.

For (1), there are still occasional wall columns that vary slightly. I don't know the cause but it doesn't seem critical at the moment.

This is really hard to notice. Due to the nature of Doom's rendering and fixed math, I'm not sure that the rendering can be absolutely perfect at all resolutions.

@ceski-1 ceski-1 changed the title Fix small rendering differences between Woof 12 and 14 Fix skies being shifted down a few pixels compared to Woof 12.0.2 Mar 20, 2024
@ceski-1
Copy link
Collaborator Author

ceski-1 commented Mar 20, 2024

Just to be safe, I tested El Juancho's config with an aspect ratio forced to 3440:1440 and unfortunately the HOM appeared. I don't want to risk regressions for such a small improvement, so I reverted the wall rendering adjustment.

@ceski-1 ceski-1 merged commit 21ed8a1 into fabiangreffrath:master Mar 20, 2024
6 checks passed
@ceski-1 ceski-1 deleted the inittex branch March 20, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants