Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial version of HOM test #1525

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

Conversation

rfomin
Copy link
Collaborator

@rfomin rfomin commented Feb 21, 2024

This is a very rough version.

How to run:

  1. Turn off dynamic resolution, set "widescreen" to "auto".
  2. Command line: woof -devparm -test -verbose -warp 1

Fix HOM at 3440x1440 resolution. This will make DRS resolution switching more
noticeable.

* More accurate `centery`/`centeryfrac` calculation in wR_SetupFreelook
  (for consistency)
@fabiangreffrath
Copy link
Owner

So this is with the changes in #1523 ?

@rfomin
Copy link
Collaborator Author

rfomin commented Feb 21, 2024

So this is with the changes in #1523 ?

I partly revert it. Now I have this:

ResetResolution: 2045x960 (426x200)
HOM 2048x1152

ResetResolution: 3438x1200 (573x200)
HOM 3440x1440

@rfomin
Copy link
Collaborator Author

rfomin commented Feb 21, 2024

I think we should letterbox (draw black bars) resolutions like 2048x1152 or 3440x1440.

src/i_video.c Show resolved Hide resolved
@ceski-1
Copy link
Collaborator

ceski-1 commented Feb 21, 2024

Try this: fov.patch

Edit: And also an ugly FOV test: fovtest.patch
Passes above test except:

  1. 1280x1024 doesn't look right and everything is misaligned. If you use the HOM cheat there is a HOM at high FOV at that resolution but it may not be detected by the test loop.
  2. The right side of the status bar has a HOM going from 3200x2400 to 3440x1440.

I used this config with a purposely odd window_width and window_height: woof.zip

@rfomin
Copy link
Collaborator Author

rfomin commented Feb 22, 2024

Try this: fov.patch

Beautiful, thanks!

  1. 1280x1024 doesn't look right and everything is misaligned. If you use the HOM cheat there is a HOM at high FOV at that resolution but it may not be detected by the test loop.

1280x1024 has an aspect ratio smaller than 4:3 (300x200 unscaled resolution). I was impressed that the engine didn't crash. We should add a check for the minimum aspect ratio, although this resolution is very rare.

  1. The right side of the status bar has a HOM going from 3200x2400 to 3440x1440.

I think we can live with that for now. After the bugfix release, I will try separate scaling factors for the UI and the game window.

@rfomin rfomin mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants