Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TS plugins outside of working directory #311

Open
geelen opened this issue Dec 10, 2020 · 0 comments
Open

Adding TS plugins outside of working directory #311

geelen opened this issue Dec 10, 2020 · 0 comments

Comments

@geelen
Copy link
Contributor

geelen commented Dec 10, 2020

Following on from #306, and fab-spec/plugin-add-fab-id#2, I've discovered that the @rollup/plugin-typescript is failing to activate on paths outside of the root directory of the project. Weirdly, when running yarn link @fab/actions to test things locally, it doesn't fail, nor can I reproduce the exact failure in #306 itself.

Basically, something strange in the neighbourhood.

In investigating, I've found that @rollup/plugin-typescript has moved on several versions and now does real typechecking, whereas we are using an old version that just strips the types and calling tsc in a separate thread. So I think the best solution would be to move to @rollup/plugin-sucrase which has the type-annotation-stripping behaviour we want.

TL;DR TODO: switch to sucrase in the rollup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant