Skip to content
This repository has been archived by the owner on Aug 9, 2020. It is now read-only.

Frontend has zero test coverage #7

Open
ezaquarii opened this issue Mar 4, 2018 · 16 comments
Open

Frontend has zero test coverage #7

ezaquarii opened this issue Mar 4, 2018 · 16 comments
Labels
first-timers-only good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ezaquarii
Copy link
Owner

No description provided.

@ezaquarii ezaquarii added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 4, 2018
@pkabra
Copy link

pkabra commented Oct 9, 2018

Hey, mind if I grab this! I think I can get the test coverage up from zero to something more 😛

@ezaquarii
Copy link
Owner Author

ezaquarii commented Oct 10, 2018

I'd be honoured! Please make yourself at home and contact me whenever you need anything.

I believe that some views would need some refactoring - feel free to send me PRs.

One thing to consider: please try not to introduce any hipster dependencies - I'm trying to keep it as vanilla as possible. Ideally I'd like to keep it as bare vue-cli as possible. Current stack includes Mocha. I use testdouble.js on chai on my other branch where I cook something, so at least those are safe.

I'm not sure if we need anything more, but if so - please let me know.

Cheers.

@yojenkins
Copy link

Hi there. I'm a first-timer looking to contribute to an open source project. I have some Vue experience and would love to help out! Are you still interested in some help on this?

@ezaquarii
Copy link
Owner Author

Yes, absolutely!

@ezaquarii
Copy link
Owner Author

Let me know if you need anything. Contacting by e-mail is probably the fastest way to get my assistance.

@yojenkins
Copy link

Great, thanks! I'll be in touch in a few days or so after I get going on this.

@yojenkins
Copy link

Hi again @ezaquarii. I've had a go at creating a test setup for the frontend using jest and vue-test-utils. However, I've hit a bit of a wall being able to get jest to import the vue components in the class-based setup that you have here with vue-property-decorator.

Do you have an example you might be able to point me to of a test setup that is similar to what we would need here?

@ezaquarii
Copy link
Owner Author

Unfortunately, I don't have any example.

Class-based views should be just that - classes, so I'd expect them to Just Work(tm). What is the nature of the problem exactly?

@yojenkins
Copy link

Sorry for the slow response! Busy week for me. I've had another go at it and realized I was making a few rookie mistakes on the previous attempt.

@ezaquarii
Copy link
Owner Author

No worries at all. Thank you for taking the effort.

Feel free to share the progress and pop for help on our new Telegram chat.

@bobbbay
Copy link

bobbbay commented Oct 14, 2019

Hey there, is this done yet? If not do you need some help? I would be honored to grab this!

@ezaquarii
Copy link
Owner Author

ezaquarii commented Oct 14, 2019 via email

@Abdullah-alfadhel
Copy link

Hello, I was wondering if you want an Arabic translator? so the project can reach a wider audience.

@ezaquarii
Copy link
Owner Author

@Abdullah-alfadhel Hi, I'm not capable of maintaining it properly, so there would need to be Arabic community to take care of maintenance.

@Abdullah-alfadhel
Copy link

@Abdullah-alfadhel Hi, I'm not capable of maintaining it properly, so there would need to be Arabic community to take care of maintenance.

What kind of maintenance you’re looking for ?

@ezaquarii
Copy link
Owner Author

  1. application needs transaltion support - so far all HTML templates are english only
  2. whenever UI changes, somebody needs to update the Arabic version as well

I'm not sure this how this would work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-timers-only good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants