bug: winget pipeline broke

[cafkafk]

The winget pipeline seems to have broken, which likely results in winget no longer getting updates. If any windows users wants to investigate further, there is a link to the failure here https://dev.azure.com/shine-oss/winget-pkgs/_build/results?buildId=6626&view=results and the PR that's blocked here https://dev.azure.com/shine-oss/winget-pkgs/_build/results?buildId=6626&view=results

[elazar125]

Looks like the links no longer work, are there new links to the 0.20.3 build you can please share? I'd be interested in trying to debug it!

[elazar125]

Looks like it's configured to check for the license file, but is looking for the old one (LICENSE) not the new one (LICENSE.txt), error message here: https://dev.azure.com/shine-oss/winget-pkgs/_build/results?buildId=15570&view=logs&j=129b3b09-7d10-5f42-7e8e-d03c270d019d&t=16eada92-7f78-5f60-1b2e-3a2ac807e0d2&l=40

Now just to figure out where this is set to open a PR...

[cafkafk]

Would this mean that renaming LICENSE.txt -> LICENSE could fix this? May be easier if reuse allows it

[elazar125]

Looks like actually changing it to LICENCE (note the C) is what would do it for a quick and dirty fix, but I suspect there's a way to actually make this work. I'm no expert in any of this, just someone using eza on Windows who'd like the new version, but I'm going down the rabbit hole to see where it goes.

From what I can tell this is set up to use vedantmgoyal9/winget-releaser which claims to use russellbanks/Komac for generating the manifests. Komac seems to work for license files with extensions as you'd expect (code is here), but in that function it's generating a URL pointing to blob/HEAD, while the eza manifests are using blob/main (and it's checking for 'license' not 'licence', so it wouldn't have picked up the old one).

Also while the extension was dropped the spelling was also changed, which I didn't notice until seeing this comment

I'll put in some more time later to see if I can figure out if just adding LICENSE.txt to some config file would do the trick. The next clue to follow is in Getting Started for winget-releaser it mentions "The action will use that version as a base to create manifests for new versions of the package", so I'm suspecting it's just copy/pasting some details from the old versions.

[jathek]

I wonder if simply merging a PR in https://github.com/eza-community/winget-pkgs which corrects the license value in https://github.com/eza-community/winget-pkgs/blob/master/manifests/e/eza-community/eza/0.19.4/eza-community.eza.locale.en-US.yaml would cause winget-releaser to use that as a base for future PRs, which would fix everything. Presumably Komac uses the most recent release manifest as the base for new manifests. Something to that effect is suggested in the failed PR for 0.20.2.