Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

once_cell crate still needed? #1169

Open
cafkafk opened this issue Oct 1, 2024 · 1 comment · May be fixed by #1181
Open

once_cell crate still needed? #1169

cafkafk opened this issue Oct 1, 2024 · 1 comment · May be fixed by #1181
Labels
question Further information is requested

Comments

@cafkafk
Copy link
Member

cafkafk commented Oct 1, 2024

Just saw #1167, we probably don't need that anymore since it should exist in the standard library now, may be worth bumping our MSRV slightly?

Of course, we shouldn't bump without looking where the ecosystem generally is by now.
@cafkafk cafkafk added the question Further information is requested label Oct 1, 2024
@cafkafk cafkafk changed the title once_cell create still needed? once_cell crate still needed? Oct 1, 2024
erwinvaneijk added a commit to erwinvaneijk/eza that referenced this issue Oct 6, 2024
@erwinvaneijk
feat(once_cell): remove dependency on once_cell
56789a6 
Rust 1.80 has a proper implementation of LazyLock, which, when used,
removes the dependency on once_cell.

- update toolchain to 1.80.0 from 1.70.0
- remove once_cell from dependencies

Fixes: eza-community#1169
@erwinvaneijk
Copy link
Contributor

It appears to be working, I'll create a PR for it.

@erwinvaneijk erwinvaneijk linked a pull request Oct 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(once_cell): remove dependency on once_cell erwinvaneijk/eza
2 participants
@erwinvaneijk @cafkafk