Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Encoder-Decoder-style architectures #340

Open
bilelomrani1 opened this issue Oct 2, 2023 · 2 comments
Open

Support for Encoder-Decoder-style architectures #340

bilelomrani1 opened this issue Oct 2, 2023 · 2 comments
Labels
feat/model Feature: models type/feature Type: Feature
Milestone

Comments

@bilelomrani1
Copy link

bilelomrani1 commented Oct 2, 2023

I regularly follow the developments on this project, and I must say that I am very interested and pleased with the direction curated-transformers is taking. The code is very understandable and high-quality, it's a pleasure to work with, congratulations!

This is perhaps already in your plans, but just to mention it here, I think a very nice addition to the project would be to have at least one reference implementation of an encoder-decoder style Transformers, such as the T5 architecture. T5 models are very popular for some tasks, especially in the < 1B parameters range which is still very relevant nowadays. Currently we have reference implementations for decoder-style and encoder-style models, but we're missing at least one reference implementation of an encoder-decoder-style architecture, perhaps with a reusable cross-attention block.

@danieldk
Copy link
Contributor

danieldk commented Oct 3, 2023

Good question. Support for encoder-decoder architectures is definitely planned. The reason that we don't have them yet is that we first focused on encoder-only to cover the standard spaCy pipelines and then decoder-only for common LLMs, but encoder-decoder is something that we want.

@shadeMe shadeMe added type/feature Type: Feature feat/model Feature: models labels Oct 4, 2023
@shadeMe shadeMe added this to the Undecided milestone Oct 4, 2023
@bilelomrani1
Copy link
Author

That's understandable, thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/model Feature: models type/feature Type: Feature
Projects
None yet
Development

No branches or pull requests

3 participants