Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests for python 3.9 #462

Open
jduerholt opened this issue Nov 18, 2024 · 4 comments
Open

Failing tests for python 3.9 #462

jduerholt opened this issue Nov 18, 2024 · 4 comments
Assignees

Comments

@jduerholt
Copy link
Contributor

Tests for python 3.9 are currently failing, reason is a fresh jax_typing release. They are already working on this: patrick-kidger/jaxtyping#271

I hope that there will be a new release by tomorrow, then we would be just fine and there is no need for any changes from our side.

cc: @bertiqwerty

@jduerholt jduerholt self-assigned this Nov 18, 2024
@R-M-Lee
Copy link
Contributor

R-M-Lee commented Nov 20, 2024

It looks to me like this is still a problem. I think these tests are failing for the same reason:
https://github.com/experimental-design/bofire/actions/runs/11936229378/job/33271365605

@jduerholt
Copy link
Contributor Author

I will further investigate it.

@R-M-Lee
Copy link
Contributor

R-M-Lee commented Nov 28, 2024

fyi: the tests I linked to were failing for a different reason

@baluyotraf
Copy link

Hello. I saw this from the jaxtyping PR. It looks like you are using | for typing.Union which is not supported in Python 3.9.

Either you use the typing.Union or do from __future__ import annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants