Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: domain checks that it makes sense (i.e. that specified constraints can be fulfilled) #165

Open
rosonaeldred opened this issue Apr 20, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hackathon

Comments

@rosonaeldred
Copy link

rosonaeldred commented Apr 20, 2023

See #163

Constraint cannot be satisfied with given example.
Would be nice (for randomly generating things, but also more generally -- testing?) to have the functionality in domain (as a class method) to check that the constraints can be fulfilled given the limits on inputs/outputs.
Probably should be decorated with a @validator tag.

Or is this actually already there somewhere?

I skimmed https://github.com/experimental-design/bofire/blob/d0f4d76dd08dab256ffa9fe47dbf1e0623c17c66/bofire/data_models/domain/domain.py

@rosonaeldred rosonaeldred added enhancement New feature or request good first issue Good for newcomers hackathon labels Apr 20, 2023
@rosonaeldred
Copy link
Author

@jkleinekorte ?

@rosonaeldred
Copy link
Author

@DavidWalz "standard feature for solvers" something something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hackathon
Projects
None yet
Development

No branches or pull requests

2 participants