v9.5.4b to v10a upgrade does not properly upgrade all components

[lenaertswouter]

Hello Goodrum,

Thanks for all the work to support v10a! I just wanted to report an issue I ran into while testing the upgrade process from v9.5.4b to v10a.
To make the upgrade it seems this cookbook installs the package found in the v10 ISO’s “update” folder. Initially this process seems work for major version upgrades like v10 but has some underlying issues when I look closer.

When making the jump from v9.5.4b to v10a not all components get properly upgraded. See screenshot. Also the “add and remove programs” list now shows components that shouldn’t be there. It seems to be residue from the previous version that now cannot be uninstalled anymore.

Interestingly the Veeam documentation tells us in case of unattended upgrades we need to uninstall all Veeam packages and reinstall connecting to the old configuration SQL database.
Source (see bottom section): https://helpcenter.veeam.com/docs/backup/vsphere/upgrade_vbr.html?ver=100

Would it be wise to stick to the Veeam recommendation? I think we could solve this by making the upgrade.rb resource be able to distinguish between major version upgrades or minor version updates and have it uninstall all Veeam components when an older major version is detected.

I am curious what you think about this?