From 99f4ddfe1aa9e1068f13e66dd769dcf12bcac8f1 Mon Sep 17 00:00:00 2001
From: Thomas Ubensee <34603111+tomuben@users.noreply.github.com>
Date: Fri, 15 Nov 2024 14:31:55 -0300
Subject: [PATCH] Fixed findings from OFT

---
 exaudfclient/docs/script_options_design.md    | 34 ++++++++++++-------
 .../docs/script_options_requirments.md        |  2 +-
 2 files changed, 23 insertions(+), 13 deletions(-)

diff --git a/exaudfclient/docs/script_options_design.md b/exaudfclient/docs/script_options_design.md
index ecbdbffe..e7ff1d26 100644
--- a/exaudfclient/docs/script_options_design.md
+++ b/exaudfclient/docs/script_options_design.md
@@ -317,13 +317,12 @@ Covers:
 Tags: V2
 
 ### Unknown Options Check
-`req~script-option-unknown-options-behvaior-v2~1`
-
-Implement a check which verifies that only known script options are found. Otherwise, raise an exception with information about the position and name of the unknown option.
+`dsn~script-option-unknown-options-behvaior-v2~1`
 
+Implement a check in class `ScriptOptionLinesParserCTPG` which verifies that only known script options are found. Otherwise, raise an exception with information about the position and name of the unknown option.
 
 Covers:
-- `req~script-option-removal~1`
+- `req~script-option-unknown-options-behavior-v2~1`
 
 Tags: V2
 
@@ -334,7 +333,7 @@ Implement a function in the `Converter` class which adds the script class option
 
 
 Covers:
-- `req~java-scriptclass-option-handling~1`
+- `req~java-scriptclass-option-handling-v2~1`
 
 Tags: V2
 
@@ -374,6 +373,21 @@ Covers:
 
 Tags: V2
 
+### Java %jvmoption Whitespace Handling
+`dsn~java-jvmoption-whitespace-handling~1`
+
+Define the Lexer rules to tokenize whitespace sequences.
+Implement rules which split JVM options by those token.
+
+
+Depends:
+- `dsn~java-jvmoption-handling~1`
+
+Covers:
+- `req~java-jvmoption-whitespace-handling~1`
+
+Tags: V2
+
 ### Java %jvmoption Whitespace Escape Handling
 `dsn~java-jvmoption-whitespace-esacape-handling~1`
 
@@ -385,13 +399,11 @@ Define the Lexer rules to tokenize whitespace escape sequences:
 
 Implement rules which replace those white space escape tokens which are part of a Jvm option.
 
-
-
 Depends:
-- `req~java-jvmoption-handling~1`
+- `dsn~java-jvmoption-handling~1`
 
 Covers:
-- `req~java-jvmoption-whitespace-handling~1`
+- req~java-jvmoption-whitespace-escape-handling-v2~1
 
 Tags: V2
 
@@ -404,8 +416,6 @@ The algorithm should work according to  [section CTPG based Script Import Algori
 
 Covers:
 - `req~java-import-option-replace-referenced-scripts~1`
-- `feat~java-specific-script-options~1`
-- `feat~java-specific-script-options~1`
 
 Tags: V2
 
@@ -444,4 +454,4 @@ The performance must not be slower than the old implementation.
 
 ##### Mitigation
 
-`dsn~ignore-lines-without-script-options~1` tries to mitigate this risk.
+Design decision `dsn~ignore-lines-without-script-options~1` tries to mitigate this risk.
diff --git a/exaudfclient/docs/script_options_requirments.md b/exaudfclient/docs/script_options_requirments.md
index e9bd04cb..5dc80397 100644
--- a/exaudfclient/docs/script_options_requirments.md
+++ b/exaudfclient/docs/script_options_requirments.md
@@ -192,7 +192,7 @@ Covers:
 Tags: V1
 
 ### Script Option Unknown Options Behavior V2
-`req~script-option-unknown-options-behvaior-v2~1`
+`req~script-option-unknown-options-behavior-v2~1`
 
 The parser handler must detect unknown script options and throw an exception if such an options is found.