Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TestContainer #64

Open
tomuben opened this issue Jul 22, 2021 · 0 comments
Open

Refactor TestContainer #64

tomuben opened this issue Jul 22, 2021 · 0 comments
Labels
refactoring Code improvement without behavior change

Comments

@tomuben
Copy link
Collaborator

tomuben commented Jul 22, 2021

Background

Today we have one class TestContainer which takes all arguments from client and then spawns test environment.
Independent of the kind of test database it passes all parameters to SpawnTestEnvironment.
SpawnTestEnvironment then distinguishes the kind of database and uses the internal docker db or an external provided db, see here

This causes some problems, as the interface is not well defined, see here.

Acceptance Criteria

The published interface by SpawnTestEnvironment should be clear. One idea is that the actual database is attached via DependencyInjection

@tomuben tomuben added refactoring Code improvement without behavior change source:exasol labels Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

No branches or pull requests

2 participants