From 98972c83c06cc60cd8cff2dff0047c9d9f20c56c Mon Sep 17 00:00:00 2001 From: jakobbraun Date: Tue, 22 Jun 2021 12:28:21 -0300 Subject: [PATCH] #108: Allowed configuration on javadoc plugin (#146) * #108: Allowed configuration on javadoc plugin --- doc/changes/changes_0.8.0.md | 13 +++++++++---- .../pom/plugin/JavadocPluginValidator.java | 6 +++++- .../pom/plugin/JavadocPluginValidatorTest.java | 2 +- 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/doc/changes/changes_0.8.0.md b/doc/changes/changes_0.8.0.md index db419d09..0cc9cd60 100644 --- a/doc/changes/changes_0.8.0.md +++ b/doc/changes/changes_0.8.0.md @@ -1,8 +1,12 @@ -# Project keeper maven plugin 0.8.0, released 2021-??-?? +# Project keeper maven plugin 0.8.0, released 2021-06-22 -Code name: +Code name: Added Jar Plugin -## Features: +## Summary + +In this release we added a configuration for the maven-jar-plugin to disable the default (non-fat) jar on jar_artifact builds. In addition, we added a requirement specification and design and fixed some bugs. + +## Features * #127: Added maven-jar-plugin configuration for disabling default (non-fat) jar on jar_artifact builds @@ -10,9 +14,10 @@ Code name: * #20: Added requirements and design -## Bug Fixes: +## Bug Fixes * #144 Fixed that whitespace in linkReplacement was not stripped +* #108: Allowed configuration on javadoc plugin ## Dependency Updates diff --git a/src/main/java/com/exasol/projectkeeper/validators/pom/plugin/JavadocPluginValidator.java b/src/main/java/com/exasol/projectkeeper/validators/pom/plugin/JavadocPluginValidator.java index 739687ef..072ef107 100644 --- a/src/main/java/com/exasol/projectkeeper/validators/pom/plugin/JavadocPluginValidator.java +++ b/src/main/java/com/exasol/projectkeeper/validators/pom/plugin/JavadocPluginValidator.java @@ -29,6 +29,10 @@ public ProjectKeeperModule getModule() { protected void validatePluginConfiguration(final Node plugin, final Collection enabledModules, final Consumer findingConsumer) { verifyPluginPropertyHasExactValue(plugin, "executions", findingConsumer); - verifyPluginPropertyHasExactValue(plugin, "configuration", findingConsumer); + verifyPluginPropertyHasExactValue(plugin, "configuration/charset", findingConsumer); + verifyPluginPropertyHasExactValue(plugin, "configuration/doclint", findingConsumer); + verifyPluginPropertyHasExactValue(plugin, "configuration/serialwarn", findingConsumer); + verifyPluginPropertyHasExactValue(plugin, "configuration/failOnError", findingConsumer); + verifyPluginPropertyHasExactValue(plugin, "configuration/failOnWarnings", findingConsumer); } } diff --git a/src/test/java/com/exasol/projectkeeper/validators/pom/plugin/JavadocPluginValidatorTest.java b/src/test/java/com/exasol/projectkeeper/validators/pom/plugin/JavadocPluginValidatorTest.java index 260d7eaf..fb0f4b37 100644 --- a/src/test/java/com/exasol/projectkeeper/validators/pom/plugin/JavadocPluginValidatorTest.java +++ b/src/test/java/com/exasol/projectkeeper/validators/pom/plugin/JavadocPluginValidatorTest.java @@ -20,7 +20,7 @@ class JavadocPluginValidatorTest extends AbstractMavenPluginPomValidatorTest { super(new JavadocPluginValidator()); } - @ValueSource(strings = { "executions", "executions/execution", "configuration" }) + @ValueSource(strings = { "executions", "executions/execution", "configuration", "configuration/serialwarn" }) @ParameterizedTest void testMissingExecutions(final String removeXpath) throws ParserConfigurationException, SAXException, IOException {