Apply suggestions from code review

Co-authored-by: Christoph Kuhnke <[email protected]>
exasol · Feb 8, 2024 · 83fcf45 · 83fcf45
1 parent 33480d1
commit 83fcf45
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/maven-project-crawler/src/main/java/com/exasol/projectkeeper/MavenProjectCrawlerMojo.java b/maven-project-crawler/src/main/java/com/exasol/projectkeeper/MavenProjectCrawlerMojo.java
@@ -39,7 +39,7 @@ public class MavenProjectCrawlerMojo extends AbstractMojo {
     // [impl -> dsn~eclipse-prefs-java-version~1]
     @Override
     public void execute() {
-        if (projectsToCrawl == null || projectsToCrawl.isBlank()) {
+        if (this.projectsToCrawl == null || this.projectsToCrawl.isBlank()) {
             throw new IllegalArgumentException(ExaError.messageBuilder("E-PK-MPC-64")
                     .message("Property {{property name}} is not defined or empty.", PROPERTY_PROJECTS_TO_CRAWL)
                     .mitigation("Specify property with least one pom file.").toString());

diff --git a/...r/src/main/java/com/exasol/projectkeeper/sources/analyze/generic/MavenProcessBuilder.java b/...r/src/main/java/com/exasol/projectkeeper/sources/analyze/generic/MavenProcessBuilder.java
@@ -75,11 +75,6 @@ public SimpleProcess startSimpleProcess() {
     }
 
     private static String getMavenExecutable() {
-        final OSType osType = new OsCheck().getOperatingSystemType();
-        if (osType == OSType.WINDOWS) {
-            return "mvn.cmd";
-        } else {
-            return "mvn";
-        }
+        return "mvn" + OsCheck.suffix(".cmd");
     }
 }