From d25af86118477daf25dd32da93421ec5ba9b863c Mon Sep 17 00:00:00 2001 From: Pieterjan Spoelders Date: Tue, 2 Apr 2024 10:46:18 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Christoph Pirkl <4711730+kaklakariada@users.noreply.github.com> --- doc/changes/changes_8.0.0.md | 2 +- doc/dialects/exasol.md | 1 + pom.xml | 1 - .../dialects/exasol/ExasolSqlDialectExaConnectionIT.java | 2 +- 4 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/changes/changes_8.0.0.md b/doc/changes/changes_8.0.0.md index 3d9bb9f..3c31846 100644 --- a/doc/changes/changes_8.0.0.md +++ b/doc/changes/changes_8.0.0.md @@ -1,6 +1,6 @@ # Exasol Virtual Schema 8.0.0, released 2024-04-02 -Code name: Charset is always `utf-8`, deprecated IMPORT_DATA_TYPES `FROM_RESULT_SET` value . +Code name: Charset is always `utf-8`, deprecated IMPORT_DATA_TYPES `FROM_RESULT_SET` value ## Summary diff --git a/doc/dialects/exasol.md b/doc/dialects/exasol.md index 30bcb59..ca8bce9 100644 --- a/doc/dialects/exasol.md +++ b/doc/dialects/exasol.md @@ -113,6 +113,7 @@ Pushdown query with `GENERATE_JDBC_DATATYPE_MAPPING_FOR_EXA = 'true'`: ```sql IMPORT INTO (c1 DECIMAL(36,1), c2 .... ) FROM EXA AT "EXA_CONNECTION" STATEMENT '...' ``` + ##### Data type mismatch In case you run into a `Data type mismatch` issue when using EXA import turning this property on will usually also solve the issue by providing type hints. diff --git a/pom.xml b/pom.xml index 9702db2..3670e8e 100644 --- a/pom.xml +++ b/pom.xml @@ -167,7 +167,6 @@ org.apache.maven.plugins maven-javadoc-plugin - 3.6.3 true diff --git a/src/test/java/com/exasol/adapter/dialects/exasol/ExasolSqlDialectExaConnectionIT.java b/src/test/java/com/exasol/adapter/dialects/exasol/ExasolSqlDialectExaConnectionIT.java index 13e2ee4..ed24ac2 100644 --- a/src/test/java/com/exasol/adapter/dialects/exasol/ExasolSqlDialectExaConnectionIT.java +++ b/src/test/java/com/exasol/adapter/dialects/exasol/ExasolSqlDialectExaConnectionIT.java @@ -78,7 +78,7 @@ protected Map getConnectionSpecificVirtualSchemaProperties() { // // The tests using the newer GENERATE_JDBC_DATATYPE_MAPPING_FOR_EXA switch that fixes most of the issues with strict // datatype checking on the pushed down queries - // can be found in ExasolSqlDialectExaConnectionWithDataTypesIT . + // can be found in ExasolSqlDialectExaConnectionWithDataTypesIT. @Test void testPasswordNotVisibleInImportFromExa() throws NoDriverFoundException, SQLException {